spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

Ensure html.escape() gets str type input #71

Closed cdsontag closed 3 years ago

cdsontag commented 3 years ago

The last PR changed the use of cgi.escape() to html.escape(). Apparently the old (now gone) cgi.escape() was more forgiving of mixed/wrong string types being thrown around.

This PR takes the most likely places for problems (text chunk reads from sql) and checks that they are str (converts if needed).

This is intentionally not an exhaustive scan of all pandokia code because:

This PR SHOULD get us back up and running for all of our standard pdk uses.