search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

For test page output, use flex_decode() func to guess at correct string encoding to use #75

Closed cdsontag closed 2 years ago

cdsontag commented 2 years ago

For test page output, use flex_decode() func to guess at correct string encoding to use.

When posting strings from a web page, I think it is safe to say we cannot always know the encoding being used, though 95% of the time it is utf-8.

cdsontag commented 2 years ago

Before pic:

image

and the bottom half with the actual error:

image
cdsontag commented 2 years ago

This is an after-pic, showing the mu at the very end of the output:

image
cdsontag commented 2 years ago

Going to merge since this has 2 green checks and has been demo'd already in pdk "ops".

CC @vglaidler for info though you have asked not to be tagged on PRs

vglaidler commented 2 years ago

Thanks @cdsontag , I did see this PR & I think I'd like to make an exception for any Pandokia changes that might occur going forward (ie, pls do tag me on Pandokia PRs).