search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

Fix Pytest plugin for PyTest 7.x/Pluggy 1.0 #76

Closed ariedel closed 1 year ago

ariedel commented 1 year ago

Stumbled onto this: https://mail.python.org/pipermail/pytest-dev/2015-September/003158.html and this: https://docs.pytest.org/en/7.1.x/how-to/writing_hook_functions.html They showed how to replace the deprecated __multicall__ reference in the plugin code, and now we can use Pandokia with PyTest 7.1.3 (or our current 6.2.4)

The practical upshot is that TP14 will be able to upgrade to the latest versions of PyTest and Pluggy, and we should no longer have problems trying to move to versions of Python more recent than 3.10 (PyTest 6.2.4 is the last version that worked before this fix, and the first version that ran under Python 3.10)

https://glitch.etc.stsci.edu/jwst/test/reports/user_pandeia_jwst_arr_pytest_JETC-2527_2022-10-24-09:57:37.html

dchitti-stsci commented 1 year ago

The changes here looks good to me. Can we pull this branch in to pandokia in glitch and trigger a test run based on it to verify?

ariedel commented 1 year ago

The changes here looks good to me. Can we pull this branch in to pandokia in glitch and trigger a test run based on it to verify?

Yes. The data test suites use PyTest and are fast, so we could do a quick check.

ariedel commented 1 year ago

This test run was done with pandokia set to this branch: https://glitch.etc.stsci.edu/jwst/test/reports/user_pandeia_jwst_arr_pytest_JETC-2527_2022-11-04-12:05:35.html