search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

JETC-2956: Remove deprecations #77

Closed ariedel closed 1 year ago

ariedel commented 1 year ago

Pandokia was written to use either setuptools or distutils; distutils is now due for removal (it's been deprecated since 2014) so I've removed that from the installer.

I also removed the dependency on relic, by including the minimal parts of relic that reproduce the version naming functionality.

See companion PRs in Pandeia (#5728) and Pandeia Test (#1482)

Test run link(s): https://glitch.etc.stsci.edu/jwst/test/reports/user_pandeia_jwst_arr_deprecations_JETC-2956_2022-11-29-16:59:22.html

ariedel commented 1 year ago

This test run was conducted with glitch running this branch of pandokia: https://glitch.etc.stsci.edu/pandokia.cgi?query=day_report.2&test_run=user_pandeia_jwst_cp_of_master_2022-11-30-13:58:28 The test has some failures from the ongoing target acq changes, but the test itself ran correctly.

ariedel commented 1 year ago

Relic loads the old RELIC-INFO file (if it exists) before overwriting it with any new information. What this means is that if you go back to an older version of Pandokia (the v2.0 tag or earlier) it will fail to install because the format of RELIC-INFO, despite my attempts to make it similar, isn't quite close enough to be reliably loaded.

There isn't really a way of fixing this short of completely reimplementing relic. If you find this ticket in the future, know that the solution is to delete the RELIC-INFO file in the pandokia repo and THEN try installing.