spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

Remove py as a dependency #80

Closed ariedel closed 1 year ago

ariedel commented 1 year ago

py has a vulnerability https://pyup.io/v/51457/f17/ (one of the ones we'd like TP14.1 to address) py developers feel the appropriate course of action is to deprecate py entirely, and moved the code pytest uses into pytest (as of pytest 7.2.0, which is in TP14) so it no longer depends on py. The only place in OUR code that uses py is Pandokia's pytest plugin.

As it turns out, changing all usage of py.code and py.test to pytest actually works properly, and removes the dependency on py.

Test run: JWST: https://glitch.etc.stsci.edu/pandokia.cgi?query=day_report.2&test_run=user_pandeia_jwst_arr_tp14.1_JETC-3160_2023-03-15-09:44:54

ariedel commented 1 year ago

The test run is not clean, but shows the same failures as this morning's master run. The engine tests contain a bunch of pytest tests that do not crash or even fail, demonstrating that this new code works (I manually pulled this branch in pandokia on the JWST Dev NFS server before running the test, just to be sure it was using this code)

vglaidler commented 1 year ago

The engine tests contain a bunch of pytest tests that do not crash or even fail, demonstrating that this new code works

@ariedel can you please confirm that the TDAs, TRAs, and logs were correctly captured? that's the only potentially weak point I can think of.

Pending that, looks good to me.

ariedel commented 1 year ago

Approved pending TDA/TRA/log confirmed successfully recorded in Pandokia.

Here's an ex-Nose test, recorded correctly: https://glitch.etc.stsci.edu/pandokia.cgi?query=detail&key_id=378020818 And another: https://glitch.etc.stsci.edu/pandokia.cgi?query=detail&key_id=378018588 A more pure pytest test: https://glitch.etc.stsci.edu/pandokia.cgi?query=detail&key_id=378017767 (not much output, but per today's nightly master run there never was) Another example: https://glitch.etc.stsci.edu/pandokia.cgi?query=detail&key_id=378019071 And all the data tests are Pytest: https://glitch.etc.stsci.edu/pandokia.cgi?query=detail&key_id=377996848