search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

JETC-3344: Make Pandokia versioning handle releases #81

Closed ariedel closed 1 year ago

ariedel commented 1 year ago

Make pandokia versioning work better, and stop the problem we were having with the rc tag from happening again.

The ultimate problem was that the regular expression is looking for a string of the pattern "2.0-15-g70aedc3e-dirty" in the output of git describe --tags --always --abbrev=8 --dirty which is to say someCharacters-decimalNumber-g unicodeCharacters-anythingElse If you try to install exactly from a tag ("2.1rc1"), it doesn't fit the pattern, so, as the documentation says, it returns None.

Relic got around this issue by looking for the None and just printing the version string it got (minus a "-dirty" if it was there).

This could also be done with str.split() instead of a regular expression, though a little less sophisticated as it wouldn't be looking for the "g" in the commit field.

Tested on tags and non-tag commits.

Test Run: https://glitch.etc.stsci.edu/hst/test/reports/user_pandeia_hst_arr_versioning_JETC-3344_2023-04-17-09:33:26.html

dchitti-stsci commented 1 year ago

When this is merged, this line in increment_RC.sh can be uncommented. https://github.com/spacetelescope/pandeia_infra/blob/master/aws/install/procedure/install_rc1.sh#L218

ariedel commented 1 year ago

I have made a new PR for the line @dchitti-stsci pointed out: https://github.com/spacetelescope/pandeia_infra/pull/163