search

spacetelescope / poppy

Physical Optics Propagation in Python
https://poppy-optics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
215 stars 72 forks source link

BUNIT of 'radian' for FITSOpticalElement #305

Closed joseph-long closed 5 years ago

joseph-long commented 5 years ago

While implementing our fancy vector apodizing phase plate in a POPPY model, I realized there's no obvious way to define a FITSOpticalElement in terms of phase alone. Because vAPPs use "vector phase", the phase map is actually defined in radians / waves independent of wavelength.

If there's interest, I'd like to add support for phase maps in radians for FITSOpticalElements. Of course, I could just subclass it myself, but in the spirit of open-source I thought I'd see if you wanted this upstream 😄

mperrin commented 5 years ago

Yeah, sure, sounds useful. -- And you've surely earned the right to just submit any PR you want into this without having to ask first! :-)