search

spacetelescope / poppy

Physical Optics Propagation in Python
https://poppy-optics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 72 forks source link

for now, skip a failing Fresnel test for the most recent scikit-image versions #555

Closed mperrin closed 1 year ago

mperrin commented 1 year ago

Workaround for #552, about a test test_Circular_Aperture_PTP_short which is known to fail for scikit-image recent versions such as 0.19.3. See comment from @douglase in #552.

For now, let's just skip that test for scikit-image more recent than version 0.18 which is known to work. This is implemented with pytest skipif. TBD sometime later to debug why the version change of skikit-image matters, and what to do about it.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ab6627) 74.78% compared to head (f657e96) 74.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #555 +/- ## ======================================== Coverage 74.78% 74.78% ======================================== Files 18 18 Lines 6499 6499 ======================================== Hits 4860 4860 Misses 1639 1639 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mperrin commented 1 year ago

I want to tag @douglase to review this, but for some reason GitHub is still not letting me, even after adding (re-adding?) @douglase to the collaborator list for this project.

BradleySappington commented 1 year ago

I want to tag @douglase to review this, but for some reason GitHub is still not letting me, even after adding (re-adding?) @douglase to the collaborator list for this project.

@mperrin - it looks like he has a pending invite. Once he accepts I think you'll be able to assign him.

mperrin commented 1 year ago

Very belatedly (but in prep for an upcoming release): @douglase could you please review this minor PR? It's about that failing test that we discussed back in Feb