Closed mperrin closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +2.32
:tada:
Comparison is base (
52aff72
) 72.14% compared to head (4e0dd01
) 74.46%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@kian1377 can you please see if you have a GitHub collaboration invite to this repo? I ought to be able to tag you as a reviewer for a PR after you accept that.
This is a followup PR to merging your CuPY GPU PR. This one (a) removes the older CUDA code which is obsoleted by the new code. We had agreed to do that as a separate PR; this is that PR. And (b) I started some brief initial documentation for the CuPy code. We can leave this pretty basic & minimal for now, or choose to expand it. What do you think? FYI, Marcio (@obi-wan76) would like to organize a release of poppy relatively soon, so my inclination is to leave the docs fairly basic for now. I assume that's all fine with you as well.
I just accepted the invitation. I am completely fine with leaving the docs more basic for now, but let me know if there is something I should contribute to the docs. As far as removing the older GPU functionality, I think it will only involve removing some code from accel_math and init.py.
On Mon, Mar 27, 2023 at 8:48 AM Marshall Perrin @.***> wrote:
External Email
@kian1377 https://github.com/kian1377 can you please see if you have a GitHub collaboration invite to this repo? I ought to be able to tag you as a reviewer for a PR after you accept that.
This is a followup PR to merging your CuPY GPU PR. This one (a) removes the older CUDA code which is obsoleted by the new code. We had agreed to do that as a separate PR; this is that PR. And (b) I started some brief initial documentation for the CuPy code. We can leave this pretty basic & minimal for now, or choose to expand it. What do you think? FYI, Marcio ( @obi-wan76 https://github.com/obi-wan76) would like to organize a release of poppy relatively soon, so my inclination is to leave the docs fairly basic for now. I assume that's all fine with you as well.
— Reply to this email directly, view it on GitHub https://github.com/spacetelescope/poppy/pull/556#issuecomment-1485380750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMCLT2UOJ5PJSSBEKDQT2OLW6GZF5ANCNFSM6AAAAAAWHRAXYM . You are receiving this because you were mentioned.Message ID: @.***>