spacetelescope / poppy

Physical Optics Propagation in Python
https://poppy-optics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 72 forks source link

Remove older CUDA GPU code, now that it's replaced by CuPY GPU code #556

Closed mperrin closed 1 year ago

mperrin commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.32 :tada:

Comparison is base (52aff72) 72.14% compared to head (4e0dd01) 74.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #556 +/- ## =========================================== + Coverage 72.14% 74.46% +2.32% =========================================== Files 18 18 Lines 6612 6547 -65 =========================================== + Hits 4770 4875 +105 + Misses 1842 1672 -170 ``` | [Impacted Files](https://app.codecov.io/gh/spacetelescope/poppy/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | |---|---|---| | [poppy/\_\_init\_\_.py](https://app.codecov.io/gh/spacetelescope/poppy/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope#diff-cG9wcHkvX19pbml0X18ucHk=) | `97.95% <100.00%> (-0.05%)` | :arrow_down: | | [poppy/accel\_math.py](https://app.codecov.io/gh/spacetelescope/poppy/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope#diff-cG9wcHkvYWNjZWxfbWF0aC5weQ==) | `43.17% <100.00%> (+8.87%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/spacetelescope/poppy/pull/556/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mperrin commented 1 year ago

@kian1377 can you please see if you have a GitHub collaboration invite to this repo? I ought to be able to tag you as a reviewer for a PR after you accept that.

This is a followup PR to merging your CuPY GPU PR. This one (a) removes the older CUDA code which is obsoleted by the new code. We had agreed to do that as a separate PR; this is that PR. And (b) I started some brief initial documentation for the CuPy code. We can leave this pretty basic & minimal for now, or choose to expand it. What do you think? FYI, Marcio (@obi-wan76) would like to organize a release of poppy relatively soon, so my inclination is to leave the docs fairly basic for now. I assume that's all fine with you as well.

kian1377 commented 1 year ago

I just accepted the invitation. I am completely fine with leaving the docs more basic for now, but let me know if there is something I should contribute to the docs. As far as removing the older GPU functionality, I think it will only involve removing some code from accel_math and init.py.

On Mon, Mar 27, 2023 at 8:48 AM Marshall Perrin @.***> wrote:

External Email

@kian1377 https://github.com/kian1377 can you please see if you have a GitHub collaboration invite to this repo? I ought to be able to tag you as a reviewer for a PR after you accept that.

This is a followup PR to merging your CuPY GPU PR. This one (a) removes the older CUDA code which is obsoleted by the new code. We had agreed to do that as a separate PR; this is that PR. And (b) I started some brief initial documentation for the CuPy code. We can leave this pretty basic & minimal for now, or choose to expand it. What do you think? FYI, Marcio ( @obi-wan76 https://github.com/obi-wan76) would like to organize a release of poppy relatively soon, so my inclination is to leave the docs fairly basic for now. I assume that's all fine with you as well.

— Reply to this email directly, view it on GitHub https://github.com/spacetelescope/poppy/pull/556#issuecomment-1485380750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMCLT2UOJ5PJSSBEKDQT2OLW6GZF5ANCNFSM6AAAAAAWHRAXYM . You are receiving this because you were mentioned.Message ID: @.***>