spacetelescope / poppy

Physical Optics Propagation in Python
https://poppy-optics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 72 forks source link

Fix CI and ReadtheDocs Build Failures #581

Closed BradleySappington closed 1 year ago

BradleySappington commented 1 year ago

Various build errors from imported package updates

BradleySappington commented 1 year ago

@obi-wan76 - some of the fixes involved changing the representation of 1.j to just be 1j Please advise if this is not an acceptable fix.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 90.00% and project coverage change: +1.84% :tada:

Comparison is base (48bec7a) 72.62% compared to head (0e0a2ad) 74.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #581 +/- ## =========================================== + Coverage 72.62% 74.46% +1.84% =========================================== Files 18 18 Lines 6549 6549 =========================================== + Hits 4756 4877 +121 + Misses 1793 1672 -121 ``` | [Files Changed](https://app.codecov.io/gh/spacetelescope/poppy/pull/581?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | |---|---|---| | [poppy/poppy\_core.py](https://app.codecov.io/gh/spacetelescope/poppy/pull/581?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope#diff-cG9wcHkvcG9wcHlfY29yZS5weQ==) | `79.75% <83.33%> (+0.55%)` | :arrow_up: | | [poppy/fresnel.py](https://app.codecov.io/gh/spacetelescope/poppy/pull/581?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope#diff-cG9wcHkvZnJlc25lbC5weQ==) | `84.95% <100.00%> (+1.71%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/spacetelescope/poppy/pull/581/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BradleySappington commented 1 year ago

This fix should also allow the dependabot builds to pass.