search

spacetelescope / poppy

Physical Optics Propagation in Python
https://poppy-optics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
211 stars 69 forks source link

Numpy 2.0 fixes:poly1d and NaN #585

Closed braingram closed 11 months ago

braingram commented 11 months ago

It appears that development scipy is no longer providing numpy functions via scipy (see https://github.com/scipy/scipy/pull/19067).

With a current scipy (1.11.0) numpy.poly1d is available at scipy.poly1d. poppy currently uses scipy.poly1d. scipy.poly1d no longer exists in scipy main. This PR updates this call to use numpy.poly1d.

Numpy 2.0 also removes NaN. This PR switches uses of NaN to nan.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
poppy/accel_math.py 43.17% <100.00%> (ø)
poppy/optics.py 81.81% <0.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.