search

spacetelescope / poppy

Physical Optics Propagation in Python
https://poppy-optics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
211 stars 69 forks source link

use PyPI upload workflow from OpenAstronomy #590

Closed zacharyburnett closed 8 months ago

zacharyburnett commented 11 months ago

Resolves SCSB-108

This PR changes the PyPI upload process to use the OpenAstronomy workflow instead of the STScI one. The workflow in this PR is configured to test the build with each pull request push, and then publish upon an official release.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9fa90e1) 74.13% compared to head (c3ecdd6) 74.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #590 +/- ## ======================================== Coverage 74.13% 74.13% ======================================== Files 18 18 Lines 6558 6558 ======================================== Hits 4862 4862 Misses 1696 1696 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BradleySappington commented 11 months ago

@zacharyburnett - If you rebase, this PR should pass tests (can't speak for codecov)

mperrin commented 9 months ago

I was reminded of this open PR. @zacharyburnett could you rebase this on current develop please, as @BradleySappington suggested a while back, so we can see if that gets the CI passing? Or I can do so myself if you concur it's OK for me to rebase and push to your PR branch (assuming "allow edits from maintainers" is enabled)?

zacharyburnett commented 9 months ago

sure thing, sorry this must have slipped through my notifications

mperrin commented 8 months ago

@BradleySappington you approved the version of this PR in the webbpsf repo. I assume this is all good to approve here in poppy as well?