search

spacetelescope / pysiaf

Handling of Science Instrument Aperture Files (SIAF) for space telescopes
https://pysiaf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
13 stars 28 forks source link

Siaf updates nirspec16may22 #243

Closed charlesrp closed 2 years ago

charlesrp commented 2 years ago

Note: generate_nirspec.py results in two assert errors that are benign - improper field points tested for NRS. The current test routines inappropriately test locations outside the valid range. Fixed test code gives good results.

Witchblade101 commented 2 years ago

I missed that this PR was against "master". We need to change it to "siaf-updates" before merging and starting the CR process.

mfixstsci commented 2 years ago

@Witchblade101 just changed the base to siaf-updates. If you want to re-review because it can cause history gaps.

Witchblade101 commented 2 years ago

History looks good so I'll go ahead and merge.