spacetelescope / pysiaf

Handling of Science Instrument Aperture Files (SIAF) for space telescopes
https://pysiaf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
13 stars 28 forks source link

Cycle 2 / OSS 9.0 enhancement: JWSTSIAF-189/JSOCINT-143 (SW+LW simultaneous coronography) #269

Closed mgennaro closed 2 years ago

mgennaro commented 2 years ago

This PR delivers the new apertures for the simultaneous operations of the SW and LW NIRCam channel in coronography, slated to become available in Cycle 2 / OSS 9.0.

mgennaro commented 2 years ago

At this time we are not asking to merge this work. The PR may be altered in the coming months, however the APT developers need a baseline version of the SIAF to proceed with some coding, in support of future OSS development. At this stage I will provide a courtesy copy of the SIAF to the developers. I opened the PR for traceability.

mgennaro commented 2 years ago

This PR can be merged, in order to allow support of the PPS 15.0 release

mfixstsci commented 2 years ago

@mgennaro looks like we have a failing test, I know we are expecting some test failures with these updates, just want to verify before merging.

mgennaro commented 2 years ago

I wouldn't know for sure if the failures you are referring to are among the expected ones. I see that the tests are failing on the test_aperture.py::test_idl_to_tel. That test seems to be using the NIRISS SIAF, but here I just added new apertures to the nircam_siaf_aperture_definitions file, so possibly that failure was there before this PR.

TBH, I am not expecting specific failures to be triggered by this PR.

mfixstsci commented 2 years ago

Okay, so according to @Witchblade101 on slack, the re-run jobs button disappears after 30 days of commits. I just made a small push and looks like the tests are still failing.

Witchblade101 commented 2 years ago

Update progress is being tracked by JWSTSIAF-255

mfixstsci commented 2 years ago

@Witchblade101 and @mgennaro I went ahead and approved the changes.