search

spacetelescope / pysiaf

Handling of Science Instrument Aperture Files (SIAF) for space telescopes
https://pysiaf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
13 stars 28 forks source link

added filter-dependent apertures for NIS_AMI1 #297

Closed goudfroo closed 1 year ago

goudfroo commented 1 year ago

Please review changes to niriss_siaf_aperture_definition.txt. I ran generate_niriss.py without errors with this file as input.

mfixstsci commented 1 year ago

Hey @goudfroo -- thank you for submitting these updates. Just to make sure, these are the apertures you are adding:

mfixstsci commented 1 year ago

@goudfroo the testing failures you see are the result of the same issue we were discussing yesterday.

goudfroo commented 1 year ago

Correct, Mees.

Regards, Paul

Paul Goudfrooij (he/him) Observatory Scientist JWST/NIRISS Deputy Branch Manager and Operations Lead Space Telescope Science Institute 3700 San Martin Drive Baltimore, MD 21218, USA My Websitehttp://bit.ly/sBvZVe

Safe Zone Member web.jhu.edu/SafeZonehttp://web.jhu.edu/SafeZone

On Apr 5, 2023, at 9:30 AM, Mees Fix @.**@.>> wrote:

Hey @goudfroohttps://urldefense.com/v3/__https://github.com/goudfroo__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!yFKwy3opqtsk7vXvsLvlW3L_IC2LQMs73ZW4b8_1ZLrfUXs2ACcpLYlpUsB2hpDmo56Epxc4ujzOJFTHfhrvpAx2fg$ -- thank you for submitting these updates. Just to make sure, these are the apertures you are adding:

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/spacetelescope/pysiaf/pull/297*issuecomment-1497490386__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!yFKwy3opqtsk7vXvsLvlW3L_IC2LQMs73ZW4b8_1ZLrfUXs2ACcpLYlpUsB2hpDmo56Epxc4ujzOJFTHfhokMIakGQ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AGBMZKIG4KY7ETHSGQXFHSLW7VXXNANCNFSM6AAAAAAWTGQIAQ__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!yFKwy3opqtsk7vXvsLvlW3L_IC2LQMs73ZW4b8_1ZLrfUXs2ACcpLYlpUsB2hpDmo56Epxc4ujzOJFTHfhrQe2ruyQ$. You are receiving this because you were mentioned.Message ID: @.***>

mfixstsci commented 1 year ago

@goudfroo awesome, is there a JIRA Ticket tracking this issue, if possible could you let @Witchblade101 and I know which one it is. Thanks!

goudfroo commented 1 year ago

@mfixstsci and @Witchblade101 - as you probably figured out, I was on vacation until today - but I think you already have the answer to your question: the Jira ticket is https://jira.stsci.edu/browse/JWSTSIAF-262.

goudfroo commented 1 year ago

Hi - just checking in, are there any outstanding issues with this merge request?

mfixstsci commented 1 year ago

@Witchblade101 anything you can see holding this up. I see the CI is failing, but thats not unusual these days.

Witchblade101 commented 1 year ago

All upgraded checks pass.