search

spacetelescope / pysiaf

Handling of Science Instrument Aperture Files (SIAF) for space telescopes
https://pysiaf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
13 stars 28 forks source link

fix `pip install` in CI #319

Closed zacharyburnett closed 1 year ago

zacharyburnett commented 1 year ago

use pip install .[test] @mfixstsci

mfixstsci commented 1 year ago

@zacharyburnett would it be possible, or make sense, to remove the line @pllim and I are talking about in #279? It would be nice to see if the tests are still passing once that is removed. Thanks!

pllim commented 1 year ago

LGTM. Yes, Python 3.7 has reached EOL and should be removed, which you did.

pllim commented 1 year ago

And yes, would be nice to remove oldest-supported-numpy though it is technically out of scope here. Depends on how many PRs you feel like opening today. Has to be done, but can be here or a follow-up.

zacharyburnett commented 1 year ago

sure, I'll remove oldest-supported-numpy (not sure why I added it in the first place, sorry), and see

zacharyburnett commented 1 year ago

Ok, this looks ready to me

mfixstsci commented 1 year ago

Boom, still passing. Thank you @zacharyburnett

pllim commented 1 year ago

A grep like this in root dir should smoke most of them out.

grep -ri python . | grep "3\.7"
zacharyburnett commented 1 year ago

Numpy also dropped supporting Python 3.8 in new versions; should the required Python version in pyproject.toml also be updated? https://github.com/spacetelescope/pysiaf/blob/f49b529e6544f2f5661f20636481029d69db9aa5/pyproject.toml#L4

There is also a reference in README.md: https://github.com/spacetelescope/pysiaf/blob/f49b529e6544f2f5661f20636481029d69db9aa5/README.md?plain=1#L136

pllim commented 1 year ago

Numpy also dropped supporting Python 3.8 in new versions

Then Python 3.8 would pick up an older numpy. Up to you whether you want to drop it or not here, but you do not have to. Though I think astropy also dropped it for upcoming v6.