spacetelescope / pysiaf

Handling of Science Instrument Aperture Files (SIAF) for space telescopes
https://pysiaf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
13 stars 28 forks source link

Update FGS J-FRAME aperture following Oct 2024 FGS1-to-JFrame k-constants update #354

Closed tonysohn closed 3 weeks ago

tonysohn commented 3 weeks ago

Changing SIAF parameters values for FGS SIAF aperture J-FRAME. Old and new parameters are:

OLD: (V3IdlYAngle, V2Ref, V3Ref) = (0.041688872 deg, 180.255 arcsec, 175.783 arcsec)
NEW (V3IdlYAngle, V2Ref, V3Ref) = (0.051342419 deg, 196.300 arcsec, 181.806 arcsec)

Note: This aperture is only used by VSS and PPS, and does not affect pointing or pipeline products.

Witchblade101 commented 3 weeks ago

@tonysohn I probably have a case of the Mondays, but these look like they were all older changes. I was expecting to see numbers changed in fgs_siaf_alignment.txt, which isn't one of the files changed in this PR. @mfix Is this just pulling changes from main into siaf_updates?

tonysohn commented 3 weeks ago

@tonysohn I probably have a case of the Mondays, but these look like they were all older changes. I was expecting to see numbers changed in fgs_siaf_alignment.txt, which isn't one of the files changed in this PR. @mfix Is this just pulling changes from main into siaf_updates?

I'll check – I may have done something wrong.