sean-lockwood commented 5 years ago

DO NOT MAKE THESE CHANGES LIVE UNTIL THE NEW WEBSITE IS UP AND RUNNING!

The Zope --> Jahia transition is currently scheduled for Monday, June 17, 2019. I updated links, but most cannot be tested until after the new site goes live.

Some additional links may need to be changed. All will need to be tested before deployment -- I suggest running sphinx's make linkcheck.

FTP link changes have been removed from this PR.

~Here are a few links I haven't updated, but will probably need to be modified:~

~Things I updated but are worthy of further consideration:~

~http://www.sdss.org/dr3/instruments/imager/#filters --> dr7~
~http://www.sdss.org/dr3/algorithms/fluxcal.html --> dr7~

Closing PR #113.

pllim commented 5 years ago

linkcheck is a good idea, though it is prone to timeout errors. Feel free to improve the CI if you want, as I don't have much time devoted to this package.

sean-lockwood commented 5 years ago

Will do.

I was thinking of linkcheck mainly as a manual check during this transition.

codecov[bot] commented 5 years ago

Codecov Report

Merging #117 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   85.18%   85.18%           
=======================================
  Files          73       73           
  Lines        5759     5759           
=======================================
  Hits         4906     4906           
  Misses        853      853

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a36dde8...ceb6e42. Read the comment docs.

pllim commented 5 years ago

@sean-lockwood , will http://www.stsci.edu/hst/observatory/crds/SIfileInfo/pysynphottables/index_phoenix_models_html be affected? I see that it is not changed in your PR.

sean-lockwood commented 5 years ago

I believe it will be. I just couldn't find the equivalent page on the new site.

pllim commented 5 years ago

@sean-lockwood , did you approach RedCat about the remaining http://www.stsci.edu/hst/observatory/crds links?

http://www.stsci.edu/hst/HST_overview -- Is this Zope? I don't know. Maybe @dancoe knows.

https://aeon.stsci.edu/ssb/trac/astrolib -- This is still online and not affected by Zope, right? We can leave it alone for now.

pllim commented 5 years ago

And what about http://www.stsci.edu/hst/acs/analysis/zeropoints ; is this going anywhere?

pllim commented 5 years ago

Oh sorry. I missed that in the diff. Nvm

sean-lockwood commented 5 years ago

I've notified Rossy about the two remaining links:

pllim commented 5 years ago

@sean-lockwood , what about http://www.stsci.edu/hst/observatory/crds/SIfileInfo/pysynphottables/index_phoenix_models_html ? It seems to redirect to a generic landing page.

pllim commented 5 years ago

Oh, never mind. Just noticed your latest commit. Thanks!

sean-lockwood commented 5 years ago

Pushed link to http://www.stsci.edu/files/live/sites/www/files/home/hst/documentation/_documents/hst_synphot.pdf

pllim commented 5 years ago

Only one left. :smile:

sean-lockwood commented 5 years ago

Last link has been pushed. Phew!

pllim commented 5 years ago

So, is this ready for merge, @sean-lockwood ?

sean-lockwood commented 5 years ago

Good to go!

pllim commented 5 years ago

Thank you very much!

spacetelescope / pysynphot

Jahia link update #117

Codecov Report