spacetelescope / pysynphot

Synthetic Photometry.

http://pysynphot.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

23 stars 21 forks source link

Add pyproject.toml #119

Closed jhunkeler closed 5 years ago

jhunkeler commented 5 years ago

Let pip install numpy before executing setup()

Now that drizzlepac requires this package, we cannot have it failing to build because numpy is missing.

EDIT: xref spacetelescope/drizzlepac#231

pllim commented 5 years ago

I would strongly advise drizzlepac to rethink this dependency...

pllim commented 5 years ago

So, why do we need this exactly? Is this not enough?

https://github.com/spacetelescope/pysynphot/blob/3344036d99e23d467adeab36ae776a84f4a846f3/setup.py#L26

codecov[bot] commented 5 years ago

Codecov Report

Merging #119 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   85.21%   85.21%           
=======================================
  Files          73       73           
  Lines        5757     5757           
=======================================
  Hits         4906     4906           
  Misses        851      851

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3344036...d0fc6d2. Read the comment docs.

jhunkeler commented 5 years ago

build-requires ensures setuptools (a version that supports pep-518) exists before attempting to install numpy. Doing it this way also ensures pip can produce a wheel package if need be.

pllim commented 5 years ago

Suddenly everything is so much more complicated. Okie dokie then.