RAD-139: Add Members Keyword to Resample Schema

spacetelescope / rad

Nancy Grace Roman Space Telescope shared attributes for processing and archive

https://rad.readthedocs.io/

Other

5 stars 20 forks source link

RAD-139: Add Members Keyword to Resample Schema #396

Closed PaulHuwe closed 5 months ago

PaulHuwe commented 5 months ago

Resolves RAD-139

Closes #340

This PR adds the members keyword to the resample schema.

Checklist

[ ] Schema changes discussed at RAD Review Board meeting
[x] Added entry in CHANGES.rst under the corresponding subsection
[x] Updated relevant roman_datamodels utilities and tests
[x] Passed romancal regression testing on Jenkins / PLWishMaster. Link: https://plwishmaster.stsci.edu:8081/job/RT/job/romancal/692/

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.38%. Comparing base (0fb1239) to head (4e5ebe5). Report is 11 commits behind head on main.

:exclamation: Current head 4e5ebe5 differs from pull request most recent head 3f397d8. Consider uploading reports for the commit 3f397d8 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #396 +/- ## ======================================= Coverage 95.38% 95.38% ======================================= Files 4 4 Lines 195 195 ======================================= Hits 186 186 Misses 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlafly commented 5 months ago

Do we expect the members to already be included as individual_image_meta.basic.filename? It is good to include this somewhere, and we aren't currently populating individual_image_meta.basic.filename, but once is probably enough?

PaulHuwe commented 5 months ago

Do we expect the members to already be included as individual_image_meta.basic.filename? It is good to include this somewhere, and we aren't currently populating individual_image_meta.basic.filename, but once is probably enough?

Yes, I would expect this information to be in individual_image_meta.basic['filename'] (basic is a table). The reason for this ticket is that romancal does set this keyword value (e.g. https://github.com/spacetelescope/romancal/blob/main/romancal/resample/resample.py#L311), so it should be added to the schema. I have not gone through romancal to see if removing that entirely would affect other steps or not.

schlafly commented 5 months ago

Okay, fine to duplicate this.