spacetelescope / roman_datamodels

Datamodel support for the roman calibration pipeline
https://roman-datamodels.readthedocs.io
Other
7 stars 21 forks source link

Fix dev testing #312

Closed WilliamJamieson closed 8 months ago

WilliamJamieson commented 8 months ago

This PR fixes the dev testing issues caused by not having an "up-to-date" pyerfa library.

Checklist

codecov[bot] commented 8 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9402e53) 97.16% compared to head (9cf1689) 97.48%. Report is 1 commits behind head on main.

:exclamation: Current head 9cf1689 differs from pull request most recent head c238477. Consider uploading reports for the commit c238477 to get more accurate results

Files Patch % Lines
src/roman_datamodels/datamodels/_datamodels.py 89.47% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #312 +/- ## ========================================== + Coverage 97.16% 97.48% +0.32% ========================================== Files 28 29 +1 Lines 2542 2709 +167 ========================================== + Hits 2470 2641 +171 + Misses 72 68 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PaulHuwe commented 8 months ago

Do you have a regression test link for this, or are there expected to be changes in RCAL as well?

WilliamJamieson commented 8 months ago

This shouldn't effect RCAL but I'll run them to be sure.

WilliamJamieson commented 8 months ago

Regression tests pass without issue: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/589/console