spacetelescope / roman_datamodels

Datamodel support for the roman calibration pipeline
https://roman-datamodels.readthedocs.io
Other
7 stars 21 forks source link

fix mk_outlier_detection #345

Closed nden closed 5 months ago

nden commented 5 months ago

Resolves RCAL-823

Closes #

This PR addresses an issue with where mk_outlier_detection is placed. Since it's a tagged node it needs to be under tagged_nodes, not common_meta. The first commit repoints roman_datamodels to rad/main and shows the failure. The second fixes it.

Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.21%. Comparing base (087a60d) to head (e84a396). Report is 16 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #345 +/- ## ========================================== - Coverage 97.56% 97.21% -0.35% ========================================== Files 30 31 +1 Lines 2788 3048 +260 ========================================== + Hits 2720 2963 +243 - Misses 68 85 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nden commented 5 months ago

And strangely it fails for me locally but doesn't fail on GA.

PaulHuwe commented 5 months ago

And strangely it fails for me locally but doesn't fail on GA.

The only change here is repointing to dev version of RAD, which had no differences with the released version.

nden commented 5 months ago

My bad, I was overwriting rad locally.