search

spacetelescope / roman_datamodels

Datamodel support for the roman calibration pipeline
https://roman-datamodels.readthedocs.io
Other
7 stars 21 forks source link

RCAL-824: Separate TVAC and FPS Models and Makers from Main #347

Closed PaulHuwe closed 5 months ago

PaulHuwe commented 5 months ago

Resolves RCAL-824

Closes #

This PR creates a suite of separate TVAC and FPS makers to freeze them and keep them separate from main development.

Checklist

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 36.71642% with 212 lines in your changes are missing coverage. Please review.

Project coverage is 78.92%. Comparing base (087a60d) to head (5c3d856). Report is 20 commits behind head on main.

:exclamation: Current head 5c3d856 differs from pull request most recent head ad109f5. Consider uploading reports for the commit ad109f5 to get more accurate results

Files Patch % Lines
...c/roman_datamodels/maker_utils/_fps_common_meta.py 12.85% 61 Missing :warning:
.../roman_datamodels/maker_utils/_tvac_common_meta.py 12.85% 61 Missing :warning:
src/roman_datamodels/maker_utils/_fps.py 28.33% 43 Missing :warning:
...rc/roman_datamodels/maker_utils/_fps_basic_meta.py 50.00% 15 Missing :warning:
...c/roman_datamodels/maker_utils/_tvac_basic_meta.py 50.00% 15 Missing :warning:
src/roman_datamodels/maker_utils/_tvac.py 82.75% 5 Missing :warning:
src/roman_datamodels/stnode/_factories.py 50.00% 4 Missing :warning:
src/roman_datamodels/stnode/_converters.py 25.00% 3 Missing :warning:
src/roman_datamodels/stnode/_node.py 70.00% 3 Missing :warning:
src/roman_datamodels/stnode/_tagged.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #347 +/- ## =========================================== - Coverage 97.56% 78.92% -18.64% =========================================== Files 30 37 +7 Lines 2788 3340 +552 =========================================== - Hits 2720 2636 -84 - Misses 68 704 +636 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PaulHuwe commented 5 months ago

Added passed Reg tests.