search

spacetelescope / roman_datamodels

Datamodel support for the roman calibration pipeline
https://roman-datamodels.readthedocs.io
Other
7 stars 21 forks source link

Skip QTables in individual image metadata. #349

Closed schlafly closed 5 months ago

schlafly commented 5 months ago

This PR adds QTable to the list of things to skip for the individual image metadata.

QTables get made as part of the PSF catalog that is now the tweakreg_catalog, instead of the old ndarray.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.09%. Comparing base (087a60d) to head (1bcce9c). Report is 18 commits behind head on main.

Files Patch % Lines
src/roman_datamodels/datamodels/_datamodels.py 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #349 +/- ## ========================================== - Coverage 97.56% 97.09% -0.47% ========================================== Files 30 31 +1 Lines 2788 3063 +275 ========================================== + Hits 2720 2974 +254 - Misses 68 89 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlafly commented 5 months ago

@PaulHuwe , I needed this in order to get the IIM to work with the new astropy Table PSF catalogs. Because those are now an astropy table rather than an ndarray the special casing in IIM was not catching them. Any objection to merging this? I think this is the only roman_datamodels update needed.

PaulHuwe commented 5 months ago

Merging.