spacetelescope / roman_datamodels

Datamodel support for the roman calibration pipeline
https://roman-datamodels.readthedocs.io
Other
7 stars 21 forks source link

Fix bug that was crashing method when attribute was an array. #350

Closed mairanteodoro closed 5 months ago

mairanteodoro commented 5 months ago

Resolves RCAL-838

This PR addresses a bug that was preventing the proper check and handling of np.NDArray arrays.

Regression Tests https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/755/

Checklist

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.50%. Comparing base (087a60d) to head (dc4ca31). Report is 21 commits behind head on main.

Files Patch % Lines
src/roman_datamodels/datamodels/_datamodels.py 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #350 +/- ## ========================================== - Coverage 97.56% 97.50% -0.06% ========================================== Files 30 37 +7 Lines 2788 3329 +541 ========================================== + Hits 2720 3246 +526 - Misses 68 83 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mairanteodoro commented 5 months ago

Can you also please include a regression test link?

I tried but I realized that I don't know how to run the regtests for roman_datamodels... do we use Roman-Developers-Pull-Requests? I tried that but got the following output:

Started by user [Mairan Teodoro](https://plwishmaster.stsci.edu:8081/user/mteodoro)
Checking out git https://github.com/mairanteodoro/roman_datamodels.git into /var/jenkins_home/workspace/RT/Roman-Developers-Pull-Requests@script to read JenkinsfileRT
The recommended git tool is: NONE
No credentials specified
Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/mairanteodoro/roman_datamodels.git
 > git init /var/jenkins_home/workspace/RT/Roman-Developers-Pull-Requests@script # timeout=10
Fetching upstream changes from https://github.com/mairanteodoro/roman_datamodels.git
 > git --version # timeout=10
 > git --version # 'git version 2.30.1'
 > git fetch --tags --force --progress -- https://github.com/mairanteodoro/roman_datamodels.git +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url https://github.com/mairanteodoro/roman_datamodels.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
Avoid second fetch
 > git rev-parse origin/bugfix_datamodels^{commit} # timeout=10
Checking out Revision dc4ca31d5420dfddd6cac0b8feb82021076f541b (origin/bugfix_datamodels)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f dc4ca31d5420dfddd6cac0b8feb82021076f541b # timeout=10
Commit message: "Add changelog entry."
First time build. Skipping changelog.
ERROR: /var/jenkins_home/workspace/RT/Roman-Developers-Pull-Requests@script/JenkinsfileRT not found
Finished: FAILURE
mairanteodoro commented 5 months ago

Can you also please include a regression test link?

Done. Thanks for the refresher on how to run regtests for RDM and RAD, @PaulHuwe!