[pre-commit.ci] pre-commit autoupdate

pre-commit-ci[bot] commented 3 months ago

updates:

PaulHuwe commented 3 months ago

@zacharyburnett Can you investigate the failed test in this PR?

zacharyburnett commented 3 months ago

ah, just looks like linting from what I assume are new rules from this version update:

tests/test_models.py:482:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
480 |     pixearea = utils.mk_pixelarea(shape=(8, 8))
481 |     assert pixearea.meta.reftype == "AREA"
482 |     assert type(pixearea.meta.photometry.pixelarea_steradians) == u.Quantity
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E721
483 |     assert type(pixearea.meta.photometry.pixelarea_arcsecsq) == u.Quantity
484 |     assert pixearea.data.dtype == np.float32
    |

tests/test_models.py:483:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
481 |     assert pixearea.meta.reftype == "AREA"
482 |     assert type(pixearea.meta.photometry.pixelarea_steradians) == u.Quantity
483 |     assert type(pixearea.meta.photometry.pixelarea_arcsecsq) == u.Quantity
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E721
484 |     assert pixearea.data.dtype == np.float32
    |

it doesn't like type() ==

spacetelescope / roman_datamodels

[pre-commit.ci] pre-commit autoupdate #354