spacetelescope / roman_datamodels

Datamodel support for the roman calibration pipeline
https://roman-datamodels.readthedocs.io
Other
7 stars 21 forks source link

metadata for release `0.21.0` #374

Closed zacharyburnett closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.68%. Comparing base (087a60d) to head (ef8089c). Report is 37 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #374 +/- ## ========================================== + Coverage 97.56% 97.68% +0.12% ========================================== Files 30 37 +7 Lines 2788 3365 +577 ========================================== + Hits 2720 3287 +567 - Misses 68 78 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zacharyburnett commented 2 months ago

did mk_sky_background get deprecated? https://github.com/spacetelescope/roman_datamodels/actions/runs/10268044787/job/28411458330#step:10:343

=========================== short test summary info ============================
FAILED tests/test_maker_utils.py::test_maker_utility_implemented[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_maker_utils.py::test_instance_valid[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_maker_utils.py::test_no_extra_fields[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_stnode.py::test_copy[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_stnode.py::test_serialization[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
================== 5 failed, 2102 passed in 82.00s (0:01:22) ===================
PaulHuwe commented 2 months ago

No, that was just added.

PaulHuwe commented 2 months ago

I see the issue.. resolving now.

PaulHuwe commented 2 months ago

I merged a PR, rerunning the tests.

zacharyburnett commented 2 months ago

looks like that fixed it!