Closed zacharyburnett closed 2 months ago
did mk_sky_background
get deprecated?
https://github.com/spacetelescope/roman_datamodels/actions/runs/10268044787/job/28411458330#step:10:343
=========================== short test summary info ============================
FAILED tests/test_maker_utils.py::test_maker_utility_implemented[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_maker_utils.py::test_instance_valid[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_maker_utils.py::test_no_extra_fields[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_stnode.py::test_copy[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_stnode.py::test_serialization[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
================== 5 failed, 2102 passed in 82.00s (0:01:22) ===================
No, that was just added.
I see the issue.. resolving now.
I merged a PR, rerunning the tests.
looks like that fixed it!
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #374 +/- ## ========================================== + Coverage 97.56% 97.68% +0.12% ========================================== Files 30 37 +7 Lines 2788 3365 +577 ========================================== + Hits 2720 3287 +567 - Misses 68 78 +10 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.