spacetelescope / roman_datamodels

Datamodel support for the roman calibration pipeline
https://roman-datamodels.readthedocs.io
Other
7 stars 21 forks source link

RCAL-853: Give VA scale factor a reasonable default #396

Closed stscieisenhamer closed 1 day ago

stscieisenhamer commented 1 month ago

WIP RCAL-853

Main PR: PR#1354

This PR gives the velocity_aberration.scale_facter meta a default working value of 1.0

Tasks

news fragment change types... - ``changes/.feature.rst``: new feature - ``changes/.bugfix.rst``: fixes an issue - ``changes/.doc.rst``: documentation change - ``changes/.removal.rst``: deprecation or removal of public API - ``changes/.misc.rst``: infrastructure or miscellaneous change
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.01%. Comparing base (087a60d) to head (65c7273). Report is 77 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #396 +/- ## ========================================== - Coverage 97.56% 97.01% -0.55% ========================================== Files 30 37 +7 Lines 2788 3316 +528 ========================================== + Hits 2720 3217 +497 - Misses 68 99 +31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

stscieisenhamer commented 1 week ago

The doc issue must be something upstream. I can investigate or leave to others.