spacetelescope / roman_datamodels

Datamodel support for the roman calibration pipeline
https://roman-datamodels.readthedocs.io
Other
7 stars 21 forks source link

test with python 3.13 #401

Closed braingram closed 1 day ago

braingram commented 1 week ago

This PR adds python 3.13 to the CI.

I also removed the py311 environment (testing with python 3.11) since we're already running py311-cov (python 3.11 while measuring coverage). This change will require updates to the branch protection rules as currently py311 is marked as required. I'm happy to remove that change from this PR (if that's preferred) just let me know.

Tasks

news fragment change types... - ``changes/.feature.rst``: new feature - ``changes/.bugfix.rst``: fixes an issue - ``changes/.doc.rst``: documentation change - ``changes/.removal.rst``: deprecation or removal of public API - ``changes/.misc.rst``: infrastructure or miscellaneous change
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.75%. Comparing base (087a60d) to head (ed6bf29). Report is 58 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #401 +/- ## ========================================== + Coverage 97.56% 97.75% +0.19% ========================================== Files 30 36 +6 Lines 2788 3434 +646 ========================================== + Hits 2720 3357 +637 - Misses 68 77 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WilliamJamieson commented 1 day ago

This will need the branch protections updated so that the linux py311 requirement is replaced by the linux py311-cov job instead. @zacharyburnett or @braingram can either of you update the branch protections after merging this?

braingram commented 1 day ago

Thanks! I updated the branch protection rules. Let me know if they look good to you or if you notice any other changes there that would be helpful.