spacetelescope / roman_datamodels

Datamodel support for the roman calibration pipeline
https://roman-datamodels.readthedocs.io
Other
7 stars 21 forks source link

RCAL-911 & 932: remove units from MOS and ELP pipelines. #405

Closed mairanteodoro closed 1 month ago

mairanteodoro commented 1 month ago

Resolves RCAL-911 Resolves RCAL-932

This PR modifies several files so that units are not used anymore. Additionally, the filename used in the regression tests was changed to remove the ggsaa component.

The information about units is still retained in the RAD schema.

Tasks

news fragment change types... - ``changes/405.general.rst``: Remove units from roman_datamodels.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.77%. Comparing base (087a60d) to head (6cfe09a). Report is 56 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #405 +/- ## ========================================== + Coverage 97.56% 97.77% +0.21% ========================================== Files 30 37 +7 Lines 2788 3456 +668 ========================================== + Hits 2720 3379 +659 - Misses 68 77 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlafly commented 1 month ago

This all looks good to me, thanks!