search

spacetelescope / roman_tools

Instructions and tutorials for Roman software tools distributed by STScI for the science community
BSD 3-Clause "New" or "Revised" License
14 stars 6 forks source link

Add IFC notebook #19

Open drlaw1558 opened 5 years ago

drlaw1558 commented 5 years ago

IFC notebook calculation to reproduce one of the simulations in TR-1701 has been added. This relies upon data added in a new pull request to pandeia_data

ariedel commented 5 years ago

Compatibility note: We're planning to revert Pandeia to v1.2.2 to fix a bug that breaks the R062 WFI filter.

Because of changes to the way precomputed "canned" backgrounds are handled in v1.3, the v1.3 (and later, such as with your additions) data won't be compatible with the v1.2.2 code.

We should discuss if we need to cherry-pick and make a new data delivery, or just wait for a v1.4 release of Pandeia (tentatively scheduled for April)

drlaw1558 commented 5 years ago

My feeling is that the actual work of producing the notebook and linking to the associated pandeia_data products is done, so waiting for v1.4 to simply merge the branch would be ok. However, Karrie should weigh in.

ariedel commented 5 years ago

The IFC notebook should now work (possibly with some modifications for names) with Pandeia v1.4, which includes the IFU files.