search

spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
32 stars 28 forks source link

Update default DQ flags in romancal #1135

Closed stscijgbot-rstdms closed 6 months ago

stscijgbot-rstdms commented 8 months ago

Issue RCAL-786 was created on JIRA by Eddie Schlafly:

See https://jira.stsci.edu/browse/RSOCDR-123 for details.

stscijgbot-rstdms commented 7 months ago

Comment by Mairan Teodoro on JIRA:

Waiting for RTB to review the list of data quality flags and identify which should be considered acceptable for default data processing.

stscijgbot-rstdms commented 7 months ago

Comment by Mairan Teodoro on JIRA:

Draft PR here: #1170

stscijgbot-rstdms commented 6 months ago

Comment by Mairan Teodoro on JIRA:

From Eddie Schlafly (PR discussion):

"{_}In our discussion at the last tag up, we decided that we should follow the Webb precedent and require that things like DEAD also have DO_NOT_USE set in the mask files. We need only be responsible for "new" reasons to set a pixel as DO_NOTUSE. The only one of those of which I am aware is when a pixel is too saturated to such that no ramp can be fit. We address that case here:{} _[https://github.com/spacetelescope/romancal/blob/main/romancal/ramp_fitting/ramp_fit_step.py#L367-L376]_

{_}So I think we can close this DR without any new development work. I don't think we need to add DEAD to this list, since it should imply DO_NOTUSE in the mask files. i.e., I think we can just close this PR---sorry!{}"