spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
31 stars 28 forks source link

RCAL-801: update skymatch to return updated models if the input is an asn #1208

Closed mairanteodoro closed 5 months ago

mairanteodoro commented 5 months ago

Resolves RCAL-801

This PR ensures that SkyMatchStep always returns a ModelContainer with the updated datamodel.

I believe SkyMatchStep is due some refactoring (specifically regarding the intended use of memory management, as seen in JWST's SkyMatchStep), but I think that it should be done separately from the current PR.

Regression Tests

Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.84%. Comparing base (1898ca5) to head (1e2cff6). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1208 +/- ## ========================================== + Coverage 76.78% 76.84% +0.06% ========================================== Files 113 113 Lines 7933 7933 ========================================== + Hits 6091 6096 +5 + Misses 1842 1837 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.