spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

rcal-827 Add regression test for skycell mosaic generation #1222

Open ddavis-stsci opened 2 months ago

ddavis-stsci commented 2 months ago

Resolves RCAL-827

Closes #

This PR adds a regression test for the L3 resampling of input image onto a skycell.

Checklist

schlafly commented 2 months ago

e.g., something like this: https://github.com/spacetelescope/romancal/blob/main/romancal/scripts/make_regtestdata.sh#L175-L179

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.21%. Comparing base (74a137c) to head (f8fd6c4).

Files Patch % Lines
romancal/pipeline/mosaic_pipeline.py 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1222 +/- ## ========================================== - Coverage 79.39% 77.21% -2.18% ========================================== Files 117 114 -3 Lines 8076 8028 -48 ========================================== - Hits 6412 6199 -213 - Misses 1664 1829 +165 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1222/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | |---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `?` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ddavis-stsci commented 2 months ago

I'm not sure why the test needs to add asn_from_list? In this case the L3_mosaic_asn.json is constructed to match a skycell. If the inputs are changed test will likely fail. So I'm not sure what adding the asn construction to the test gains us.

schlafly commented 2 months ago

I just want to capture whatever you did in order to produce the L3_mosaic_asn.json. If it's a fixed string, that's fine too, but let's put that string in the script.

schlafly commented 2 months ago

I think the new version of this has an issue where you wanted to do WFI01 exposures 0001 through 0003, but you did WFI01 through WFI03 instead?

In any case, I went ahead and added the creation of these regtest files to the regtest creation script here https://github.com/spacetelescope/romancal/pull/1228/files#diff-ab1578cd89f53a8e1bcabc27ab2bd67d6671c93b587d0236e33b1ffb81f7b0b4R189-R193 so I'm not worried about that part anymore.

ddavis-stsci commented 2 months ago

Oops, Yes I did mean exposures. Corrected, thanks

On 5/7/24 2:27 PM, Eddie Schlafly wrote:

I think the new version of this has an issue where you wanted to do WFI01 exposures 0001 through 0003, but you did WFI01 through WFI03 instead?

In any case, I went ahead and added the creation of these regtest files to the regtest creation script here https://github.com/spacetelescope/romancal/pull/1228/files#diff-ab1578cd89f53a8e1bcabc27ab2bd67d6671c93b587d0236e33b1ffb81f7b0b4R189-R193 https://urldefense.com/v3/__https://github.com/spacetelescope/romancal/pull/1228/files*diff-ab1578cd89f53a8e1bcabc27ab2bd67d6671c93b587d0236e33b1ffb81f7b0b4R189-R193__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!yWI1tP8HxATAHZUj9BUhjsoeSkwJ6LHOerrQ6zo714D4sXQBdIu2LzqiM57xjaeR9fIcGfGlz-kHLbk5D9G2BoDF$ so I'm not worried about that part anymore.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/spacetelescope/romancal/pull/1222*issuecomment-2099051595__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!yWI1tP8HxATAHZUj9BUhjsoeSkwJ6LHOerrQ6zo714D4sXQBdIu2LzqiM57xjaeR9fIcGfGlz-kHLbk5D2UKDU-y$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ALXCXWPX5GR7A6W3TY4WSLLZBEMHNAVCNFSM6AAAAABHJGKEKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGA2TCNJZGU__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!yWI1tP8HxATAHZUj9BUhjsoeSkwJ6LHOerrQ6zo714D4sXQBdIu2LzqiM57xjaeR9fIcGfGlz-kHLbk5DxWeTfL-$. You are receiving this because you authored the thread.Message ID: @.***>