spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

Regtest / integration fixes for B14 #1228

Closed schlafly closed 2 months ago

schlafly commented 2 months ago

This PR makes a handful of minor changes in order to get things integrated for B14. In combination with https://github.com/spacetelescope/roman_datamodels/pull/349 and the new regtest files in /grp/roman/eschlafly/romanisim/20240503 we pass tests, etc.. Some bits of this PR:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.96%. Comparing base (da44930) to head (5f777b1). Report is 22 commits behind head on main.

:exclamation: Current head 5f777b1 differs from pull request most recent head 85bcf1d. Consider uploading reports for the commit 85bcf1d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1228 +/- ## ========================================== + Coverage 76.57% 78.96% +2.39% ========================================== Files 116 117 +1 Lines 7999 8083 +84 ========================================== + Hits 6125 6383 +258 + Misses 1874 1700 -174 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1228/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.78% <ø> (ø)` | | Carriedforward from [c95032b](https://app.codecov.io/gh/spacetelescope/romancal/commit/c95032b5d3fe0b2745a3c55fecee0872d98255a4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.