search

spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
31 stars 28 forks source link

Also ignore version information in Table schema meta. #1229

Closed schlafly closed 4 months ago

schlafly commented 4 months ago

This PR ignores an additional Table metadata version field in compare_asdf.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.93%. Comparing base (5f777b1) to head (2a4a78d). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1229 +/- ## ========================================== - Coverage 78.96% 78.93% -0.03% ========================================== Files 117 117 Lines 8083 8086 +3 ========================================== Hits 6383 6383 - Misses 1700 1703 +3 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1229/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1229/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.78% <ø> (ø)` | | Carriedforward from [5f777b1](https://app.codecov.io/gh/spacetelescope/romancal/commit/5f777b148cb53d655ba6ccf3629479be7377d61d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlafly commented 4 months ago

Passing regtests here: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/740/