search

spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
31 stars 28 forks source link

ResampleStep is not performing sky subtraction properly #1232

Closed stscijgbot-rstdms closed 3 months ago

stscijgbot-rstdms commented 4 months ago

Issue RCAL-837 was created on JIRA by Mairan Teodoro:

Even though SkyMatchStep is populating {}meta.background{}, the following conditional check in ResampleStep is not working because one of the attributes created by SkyMatchStep has the wrong datatype. Indeed, meta.background.subtracted should be a boolean but is currently being set as None due to a bug in the logic when setting its value in {}SkyMatchStep{}.

https://github.com/spacetelescope/romancal/blob/a1b0295e14afe51c3b32ab5e9de2329cf8fe7a67/romancal/resample/resample.py#L308

stscijgbot-rstdms commented 4 months ago

Comment by Mairan Teodoro on JIRA:

PR for review: #1233