spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

RCAL-828: add PSF bits to source catalog. #1243

Closed mairanteodoro closed 1 month ago

mairanteodoro commented 1 month ago

Resolves RCAL-828

This PR addresses the implementation of PSF photometry into SourceCatalogStep.

Regression Tests Regression tests are all passing. ~https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/775/~ ~https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/798/~ ~https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/808/~ ~https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/809/~ https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/814/

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.99%. Comparing base (9662356) to head (87dd5e5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1243 +/- ## ========================================== + Coverage 78.87% 78.99% +0.11% ========================================== Files 117 117 Lines 8071 8101 +30 ========================================== + Hits 6366 6399 +33 + Misses 1705 1702 -3 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.79% <ø> (ø)` | | Carriedforward from [9662356](https://app.codecov.io/gh/spacetelescope/romancal/commit/9662356c1e8fd7771a5dda49ac90f4996d7a2c50?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mairanteodoro commented 1 month ago

Comparison between the results from source_detection and source_catalog (for all plots, the vertical and horizontal lines correspond to the range between -0.01 and +0.01 pix): det_vs_cat

Comparison between the results from source_detection and the "truth" coordinates used in romanisim for source injection: det_vs_truth

Comparison between the results from source_catalog and the "truth" coordinates used in romanisim for source injection: cat_vs_truth