spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

Source catalog step needs to accept an input association #1253

Closed stscijgbot-rstdms closed 4 weeks ago

stscijgbot-rstdms commented 1 month ago

Issue RCAL-847 was created on JIRA by David Davis:

The source catalog step needs to accept an input association. It currently fails with


strun --debug romancal.step.SourceCatalogStep src_det_asn.json
2024-05-29 09:07:14,251 - stpipe - WARNING - Input dataset is not an instance of AbstractDataModel.
2024-05-29 09:07:14,251 - stpipe - INFO - PARS-SOURCECATALOGSTEP: CRDS parameter reference retrieval disabled.
2024-05-29 09:07:14,252 - stpipe.SourceCatalogStep - INFO - SourceCatalogStep instance created.
2024-05-29 09:07:14,331 - stpipe.SourceCatalogStep - INFO - Step SourceCatalogStep running with args ('src_det_asn.json',).
2024-05-29 09:07:14,332 - stpipe.SourceCatalogStep - INFO - Step SourceCatalogStep parameters are: {'pre_hooks': [], 'post_hooks': [], 'output_file': None, 'output_dir': None, 'output_ext': '.asdf', 'output_use_model': False, 'output_use_index': True, 'save_results': True, 'skip': False, 'suffix': 'cat', 'search_output_file': True, 'input_dir': '', 'bkg_boxsize': 1000, 'kernel_fwhm': 2.0, 'snr_threshold': 3.0, 'npixels': 25, 'deblend': False, 'aperture_ee1': 30, 'aperture_ee2': 50, 'aperture_ee3': 70, 'ci1_star_threshold': 2.0, 'ci2_star_threshold': 1.8}
----------------------------------------------------------------------
ERROR RUNNING STEP 'SourceCatalogStep':
    Open requires a filepath, file-like object, or Roman datamodel
----------------------------------------------------------------------
> /Users/ddavis/miniconda3/envs/rcal_dev/lib/python3.11/site-packages/roman_datamodels/datamodels/_utils.py(55)_open_path_like()
-> raise TypeError("Open requires a filepath, file-like object, or Roman datamodel") from err```
schlafly commented 1 month ago

We talked about this a little on Thursday. Because the L3 source catalog gets run after resample, I think we decided that we do not need to accept an input association. Dave, if you agree, could you close? Thanks!

stscijgbot-rstdms commented 4 weeks ago

Comment by Mairan Teodoro on JIRA:

As it has been decided that the SourceCatalogStep should not accept an association file as input, this ticket has been closed with no work.