spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

Refactor DQInitStep to use the RampModel method of creating ramps #1258

Closed stscieisenhamer closed 1 month ago

stscieisenhamer commented 1 month ago

Resolves RCAL-833

Related PRs

This PR addresses an issue discovered while trying to run the pipeline on TVAC data where tags were not being converted appropriately. This was occurring in the DQInitStep with dedicated code for the meta copying. In conjuction with the RDM PR, the meta copy is fixed.

Checklist

stscieisenhamer commented 1 month ago

Regression attempt #1

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.92%. Comparing base (1aec135) to head (1951711). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1258 +/- ## ========================================== - Coverage 78.93% 78.92% -0.02% ========================================== Files 117 117 Lines 8086 8065 -21 ========================================== - Hits 6383 6365 -18 + Misses 1703 1700 -3 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1258/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.79% <ø> (+0.01%)` | :arrow_up: | Carriedforward from [c4ed963](https://app.codecov.io/gh/spacetelescope/romancal/commit/c4ed96307a3f344ab30f1f16133c1cdcb7bba419?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stscieisenhamer commented 1 month ago

CI failures due to not having the updated RDM pr 352 merged.

stscieisenhamer commented 1 month ago

Regression try #2 to confirm pyproject changes: Success.