spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

rcal-846 Add mosaic info to the science products RTD page #1262

Closed ddavis-stsci closed 1 month ago

ddavis-stsci commented 1 month ago

Resolves RCAL-846

Closes #1252

This PR adds a description of the i2d (mosaic) data to read-the-docs.

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.85%. Comparing base (1aec135) to head (51ba23b). Report is 5 commits behind head on main.

:exclamation: Current head 51ba23b differs from pull request most recent head 7bf99f1

Please upload reports for the commit 7bf99f1 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1262 +/- ## ========================================== - Coverage 78.93% 78.85% -0.09% ========================================== Files 117 117 Lines 8086 8088 +2 ========================================== - Hits 6383 6378 -5 - Misses 1703 1710 +7 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1262/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.84% <ø> (+0.06%)` | :arrow_up: | Carriedforward from [1aec135](https://app.codecov.io/gh/spacetelescope/romancal/commit/1aec135149bc96e7b8f7ef208dc3daa1f9139a9b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlafly commented 1 month ago

Was this the number of input SCAs or exposures? If the latter, maybe the number of SCAs is >32, and this is the fact that we're not grouping? But yeah, I suspect a bug of some kind.

ddavis-stsci commented 1 month ago

8 detectors, the asn code looks for individual detector files that touch a skycell. In this case WFI01, WFI02, WFI10 & WFI11 for the given visit and skycell.

On 6/3/24 4:52 PM, Eddie Schlafly wrote:

Was this the number of input SCAs or exposures? If the latter, maybe the number of SCAs is >32, and this is the fact that we're not grouping? But yeah, I suspect a bug of some kind.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/spacetelescope/romancal/pull/1262*issuecomment-2146101116__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!2kc26SIo1VJ3lgqZNjJX5H3ZHyHD6Xv_9J-jX5Ljo-yT2FSzotAFclSfeuEV_9oigEirfuG8-zR9G9lRZVZSNNB8$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ALXCXWL2QWP2WYNSJHLYNLDZFTJPBAVCNFSM6AAAAABIXECV5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWGEYDCMJRGY__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!2kc26SIo1VJ3lgqZNjJX5H3ZHyHD6Xv_9J-jX5Ljo-yT2FSzotAFclSfeuEV_9oigEirfuG8-zR9G9lRZVGoEwuJ$. You are receiving this because you authored the thread.Message ID: @.***>