Closed mairanteodoro closed 3 weeks ago
@mairanteodoro would you also add the webbpsf markers to these tests? They're causing failures in stpipe: https://github.com/spacetelescope/stpipe/actions/runs/9445531594/job/26013349354#step:10:3493
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.99%. Comparing base (
f22e4b9
) to head (1f15b90
).:exclamation: Current head 1f15b90 differs from pull request most recent head 2ffa25c
Please upload reports for the commit 2ffa25c to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Would you run this with the GA regtests (which will trigger sonar scan) to check that there's no other issues? @zacharyburnett put together some great documentation on this: https://github.com/spacetelescope/RegressionTests/blob/main/docs/run_regression_tests.md and should be able to set you up with permissions (if you don't see the 'Run Workflow' button).
Would you run this with the GA regtests (which will trigger sonar scan) to check that there's no other issues? @zacharyburnett put together some great documentation on this:
https://github.com/spacetelescope/RegressionTests/blob/main/docs/run_regression_tests.md
and should be able to set you up with permissions (if you don't see the 'Run Workflow' button).
Thanks for the suggestion, Brett! I will take a look into it.
This should fix the issue mentioned by George Cleary on Slack: https://stsci.slack.com/archives/C01FP900P38/p1718113704757169
Checklist
CHANGES.rst
under the corresponding subsection