spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

Fix comparison operator. #1269

Closed mairanteodoro closed 3 weeks ago

mairanteodoro commented 3 weeks ago

This should fix the issue mentioned by George Cleary on Slack: https://stsci.slack.com/archives/C01FP900P38/p1718113704757169

Checklist

braingram commented 3 weeks ago

@mairanteodoro would you also add the webbpsf markers to these tests? They're causing failures in stpipe: https://github.com/spacetelescope/stpipe/actions/runs/9445531594/job/26013349354#step:10:3493

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.99%. Comparing base (f22e4b9) to head (1f15b90).

:exclamation: Current head 1f15b90 differs from pull request most recent head 2ffa25c

Please upload reports for the commit 2ffa25c to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1269 +/- ## ======================================= Coverage 78.99% 78.99% ======================================= Files 117 117 Lines 8101 8101 ======================================= Hits 6399 6399 Misses 1702 1702 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1269/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1269/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.79% <ø> (ø)` | | Carriedforward from [f22e4b9](https://app.codecov.io/gh/spacetelescope/romancal/commit/f22e4b9f68137bcca7f911c8c1496ff43cff0d6a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 3 weeks ago

Would you run this with the GA regtests (which will trigger sonar scan) to check that there's no other issues? @zacharyburnett put together some great documentation on this: https://github.com/spacetelescope/RegressionTests/blob/main/docs/run_regression_tests.md and should be able to set you up with permissions (if you don't see the 'Run Workflow' button).

mairanteodoro commented 3 weeks ago

Would you run this with the GA regtests (which will trigger sonar scan) to check that there's no other issues? @zacharyburnett put together some great documentation on this:

https://github.com/spacetelescope/RegressionTests/blob/main/docs/run_regression_tests.md

and should be able to set you up with permissions (if you don't see the 'Run Workflow' button).

Thanks for the suggestion, Brett! I will take a look into it.