Open nden opened 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.89%. Comparing base (
6b1c696
) to head (77d1f40
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think I missed the part of this test that checks that things round trip?
This WCS contains only the v2v3tosky bit, and not the CRDS distortion bit. That's good since it makes for an easier unit test but bad since it won't catch the only case we have had problems here so far, where the failure to round trip was in the CRDS distortion file. Do we intend to check the CRDS reference files as well?
I note that the bounding box is inconsistent with the size of the image, and that we're pretending that the sizes of the pixels are ~1". I think that's likely fine. romanisim has some code for making up a "fake" distortion function here https://github.com/spacetelescope/romanisim/blob/main/romanisim/tests/test_wcs.py#L19-L38 and using that in unit tests instead of the actual CRDS distortion functions. It's not obvious to me that that is helpful here but I link it in case you would have rather used some kind of distortion function.
Resolves RCAL-856
Closes #1272
This PR is the last one in a chain of PRs aiming to fix roundtripping of WCS transforms. The only change here is to test data, ensuring the WCS is consistent and the inverse is wihtin the bounding box.
The order the PRs should be merged is
Checklist
CHANGES.rst
under the corresponding subsection