spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

webbpsf failures and numpy 2.0 #1280

Closed braingram closed 3 days ago

braingram commented 2 weeks ago

The romancal usage of webbpsf combined with numpy 2.0 leads to many failures like the following:

romancal/lib/tests/test_psf.py:70: in setup_inputs
    psf_model, centroids = create_gridded_psf_model(
romancal/lib/psf.py:181: in create_gridded_psf_model
    gridmodel = inst.create_grid()
.tox/py311-ddtrace-webbpsf/lib/python3.11/site-packages/webbpsf/gridded_library.py:396: in create_grid
    model = self.to_model(psf_arr, meta)
.tox/py311-ddtrace-webbpsf/lib/python3.11/site-packages/webbpsf/gridded_library.py:436: in to_model
    ndd.meta['grid_xypos'] = [((float(ndd.meta[key][0].split(',')[1].split(')')[0])),
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

.0 = <odict_iterator object at 0x7f6c779f12b0>

>   ndd.meta['grid_xypos'] = [((float(ndd.meta[key][0].split(',')[1].split(')')[0])),
                              (float(ndd.meta[key][0].split(',')[0].split('(')[1])))
                              for key in ndd.meta.keys() if "DET_YX" in key]
E   ValueError: could not convert string to float: ' np.float64(100.0'

See the full log here: https://github.com/spacetelescope/romancal/actions/runs/9569032524/job/26380655507#step:10:329

These failures aren't seen when running webbpsf with numpy 2.0: https://github.com/spacetelescope/webbpsf/pull/871 and might be:

This is one of the issues preventing romancal from using numpy 2.0