spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

unpin webbpsf #1288

Closed braingram closed 3 days ago

braingram commented 1 week ago

This PR removes the exact pin for webbpsf. The pinned version is not numpy 2.0 compatible and is one of the limitations preventing romancal from using numpy 2.0: https://github.com/spacetelescope/romancal/issues/1280

I pinged @bmorris3 to see if he recalls the reason for the exact pin in: https://github.com/spacetelescope/romancal/pull/841

This PR will test if removing the pin causes test failures.

Regression tests run with no errors at: https://github.com/spacetelescope/RegressionTests/actions/runs/9652327358

Fixes https://github.com/spacetelescope/romancal/issues/1280

Checklist

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.39%. Comparing base (6a7fbb2) to head (2ae8207).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1288 +/- ## ======================================= Coverage 79.39% 79.39% ======================================= Files 117 117 Lines 8076 8076 ======================================= Hits 6412 6412 Misses 1664 1664 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1288/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.84% <ø> (ø)` | | Carriedforward from [6a7fbb2](https://app.codecov.io/gh/spacetelescope/romancal/commit/6a7fbb2675a39c1196d739742c8ca579130f2c51?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.