spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

add upper pin for photutils #1291

Closed braingram closed 3 days ago

braingram commented 6 days ago

photutils 1.13.0 is causing test failures and appears to be incompatible with romancal: https://github.com/spacetelescope/RegressionTests/actions/runs/9716745018/job/26821243423#step:27:2134

I started a CI run with main here which has all the test_psf tests failing: https://github.com/spacetelescope/romancal/actions/runs/9717591343/job/26823614739

This PR adds an upper pin for photutils.

Checklist

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.39%. Comparing base (7ae6c53) to head (83fb9c0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1291 +/- ## ======================================= Coverage 79.39% 79.39% ======================================= Files 117 117 Lines 8076 8076 ======================================= Hits 6412 6412 Misses 1664 1664 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1291/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1291/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.84% <ø> (ø)` | | Carriedforward from [7ae6c53](https://app.codecov.io/gh/spacetelescope/romancal/commit/7ae6c53fee673a828118adea855259721330db83?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

larrybradley commented 6 days ago

I took a quick look and the add_sources function in lib/tests/test_psf used private attributes in PSFPhotometry that no longer exist. There's actually no need to use PSFPhotometry in that function; photutils has standalone function(s) for creating simulated images from models. I will fix this function next week.

larrybradley commented 6 days ago

Also, it's probably a good idea to add photutils to the devdeps CI test job.

braingram commented 4 days ago

Thanks.

@ddavis-stsci how about we merge this to fix the tests until @larrybradley updates them for the new version.

The devdeps are testing against photutils main: https://github.com/spacetelescope/romancal/actions/runs/9741383642/job/26880534266#step:10:101