Closed braingram closed 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.39%. Comparing base (
7ae6c53
) to head (83fb9c0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I took a quick look and the add_sources
function in lib/tests/test_psf
used private attributes in PSFPhotometry
that no longer exist. There's actually no need to use PSFPhotometry
in that function; photutils
has standalone function(s) for creating simulated images from models. I will fix this function next week.
Also, it's probably a good idea to add photutils
to the devdeps CI test job.
Thanks.
@ddavis-stsci how about we merge this to fix the tests until @larrybradley updates them for the new version.
The devdeps are testing against photutils main: https://github.com/spacetelescope/romancal/actions/runs/9741383642/job/26880534266#step:10:101
photutils 1.13.0 is causing test failures and appears to be incompatible with romancal: https://github.com/spacetelescope/RegressionTests/actions/runs/9716745018/job/26821243423#step:27:2134
I started a CI run with main here which has all the
test_psf
tests failing: https://github.com/spacetelescope/romancal/actions/runs/9717591343/job/26823614739This PR adds an upper pin for photutils.
Checklist
CHANGES.rst
under the corresponding subsection