spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
28 stars 28 forks source link

Fix psf tests #1293

Open larrybradley opened 3 days ago

larrybradley commented 3 days ago

Closes #1292

This PR fixes the add_sources function in the test_psf.py module. The previous version used a private attribute in PSFPhotometry, which was removed in photutils 1.13.0. I rewrote the add_sources function using a photutils function designed for creating simulated images from models. The function requires >= 1.13.0, so I updated the min version of photutils.

Checklist

larrybradley commented 3 days ago

The oldestdeps test is failing. photutils 1.13.0 requires numpy 1.23+, but romancal requires numpy 1.22+. Can I bump min numpy? Note that astropy and other packages that follow NEP-29 (https://numpy.org/neps/nep-0029-deprecation_policy.html) also require numpy 1.23+.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.39%. Comparing base (74a137c) to head (19bf7b5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1293 +/- ## ======================================= Coverage 79.39% 79.39% ======================================= Files 117 117 Lines 8076 8076 ======================================= Hits 6412 6412 Misses 1664 1664 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1293/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1293/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.84% <ø> (ø)` | | Carriedforward from [74a137c](https://app.codecov.io/gh/spacetelescope/romancal/commit/74a137c93b76e0464972bf8d469314f012fe0a15?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.