Closed braingram closed 1 month ago
Attention: Patch coverage is 12.50000%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 78.56%. Comparing base (
ee8288f
) to head (c9ba2ff
).
Files | Patch % | Lines |
---|---|---|
romancal/regtest/regtestdata.py | 12.50% | 14 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I also vote for this one going in after https://github.com/spacetelescope/romancal/pull/1241
@ddavis-stsci I requested your review since using get_asn
would simplify the regression test you're adding in https://github.com/spacetelescope/romancal/pull/1222
@mairanteodoro Thanks for taking a look. I'm seeing this PR as not approved. Is that intentional? If so, is there an issue to address or another person to approve it. Thanks again.
@mairanteodoro Thanks for taking a look. I'm seeing this PR as not approved. Is that intentional? If so, is there an issue to address or another person to approve it. Thanks again.
I was just deferring the approval to @ddavis-stsci. I will aprove it now.
Thanks!
@ddavis-stsci Does this look good to you? It will be useful for https://github.com/spacetelescope/romancal/pull/1348
I'm happy to either wait until after https://github.com/spacetelescope/romancal/pull/1348 is merged and then update this PR or merge this PR so you can update https://github.com/spacetelescope/romancal/pull/1348
Thanks! I'm re-running the regtests now (same link as above).
EDIT: this needs a new run (and new link) due to the patch table environment variable changes Run here: https://github.com/spacetelescope/RegressionTests/actions/runs/10267768330
Regtests all passed.
Fixes https://github.com/spacetelescope/romancal/issues/1318
This PR uncomments
get_asn
and uses it in the 2 regtests I found that pull associations from artifactory.This allows the regtests to be simplified by not requiring them to:
get_asn
automatically sets thertdata.input
attribute so the test does not need to set thisRegression tests running: https://github.com/spacetelescope/RegressionTests/actions/runs/10267768330
Checklist
CHANGES.rst
under the corresponding subsection