spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
31 stars 28 forks source link

uncomment and use get_asn #1320

Closed braingram closed 1 month ago

braingram commented 2 months ago

Fixes https://github.com/spacetelescope/romancal/issues/1318

This PR uncomments get_asn and uses it in the 2 regtests I found that pull associations from artifactory.

This allows the regtests to be simplified by not requiring them to:

Regression tests running: https://github.com/spacetelescope/RegressionTests/actions/runs/10267768330

Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (ee8288f) to head (c9ba2ff).

Files Patch % Lines
romancal/regtest/regtestdata.py 12.50% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1320 +/- ## ========================================== - Coverage 78.69% 78.56% -0.14% ========================================== Files 117 117 Lines 7844 7860 +16 ========================================== + Hits 6173 6175 +2 - Misses 1671 1685 +14 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/romancal/pull/1320/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [nightly](https://app.codecov.io/gh/spacetelescope/romancal/pull/1320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `62.26% <ø> (ø)` | | Carriedforward from [ee8288f](https://app.codecov.io/gh/spacetelescope/romancal/commit/ee8288f14bc8bf1306ab00bcea05cc16a11ced17?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 2 months ago

I also vote for this one going in after https://github.com/spacetelescope/romancal/pull/1241

braingram commented 2 months ago

@ddavis-stsci I requested your review since using get_asn would simplify the regression test you're adding in https://github.com/spacetelescope/romancal/pull/1222

braingram commented 1 month ago

@mairanteodoro Thanks for taking a look. I'm seeing this PR as not approved. Is that intentional? If so, is there an issue to address or another person to approve it. Thanks again.

mairanteodoro commented 1 month ago

@mairanteodoro Thanks for taking a look. I'm seeing this PR as not approved. Is that intentional? If so, is there an issue to address or another person to approve it. Thanks again.

I was just deferring the approval to @ddavis-stsci. I will aprove it now.

braingram commented 1 month ago

Thanks!

@ddavis-stsci Does this look good to you? It will be useful for https://github.com/spacetelescope/romancal/pull/1348

I'm happy to either wait until after https://github.com/spacetelescope/romancal/pull/1348 is merged and then update this PR or merge this PR so you can update https://github.com/spacetelescope/romancal/pull/1348

braingram commented 1 month ago

Thanks! I'm re-running the regtests now (same link as above).

EDIT: this needs a new run (and new link) due to the patch table environment variable changes Run here: https://github.com/spacetelescope/RegressionTests/actions/runs/10267768330

braingram commented 1 month ago

Regtests all passed.