search

spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
32 stars 28 forks source link

Update source catalog results with tweaked astrometry #1371

Closed stscijgbot-rstdms closed 1 month ago

stscijgbot-rstdms commented 2 months ago

Issue RCAL-895 was created on JIRA by Mairan Teodoro:

We create the source catalog before tweakreg so that we can use the measured positions to update the WCS of the image. The source catalog also contains ra/dec for the sources based on the pre-tweakreg WCS, but we should update those positions to use the post-tweakreg WCS once we have it.

stscijgbot-rstdms commented 2 months ago

Comment by Mairan Teodoro on JIRA:

Eddie Schlafly Few questions:

These are the columns present in the current cat file table:


'label','xcentroid','ycentroid','ra_centroid','dec_centroid','aper_bkg_flux','aper_bkg_flux_err','aper30_flux','aper30_flux_err','aper50_flux','aper50_flux_err','aper70_flux','aper70_flux_err','aper_total_flux','aper_total_flux_err','CI_50_30','CI_70_50','CI_70_30','flags','is_extended','sharpness','roundness','nn_label','nn_dist','isophotal_flux','isophotal_flux_err','isophotal_area','semimajor_sigma','semiminor_sigma','ellipticity','orientation','sky_orientation','ra_bbox_ll','dec_bbox_ll','ra_bbox_ul','dec_bbox_ul','ra_bbox_lr','dec_bbox_lr','ra_bbox_ur','dec_bbox_ur','flag_psf','x_psf','x_psf_err','y_psf','y_psf_err','flux_psf','flux_psf_err' ```
schlafly commented 2 months ago

Thanks Mairan. Let's update all of the ra/decs. i.e., ra/dec_centroid, ra/decbbox*. Let's only do it for the ELP---I guess that means an additional argument to tweakreg that the ELP sets? Yes; I don't currently see an ra_psf, dec_psf in your list, but we should add that if we don't have it, with the values from the updated astrometry.

On Mon, Aug 19, 2024 at 4:36 PM stscijgbot-rstdms @.***> wrote:

Comment by Mairan Teodoro https://jira.stsci.edu/secure/ViewProfile.jspa?name=mteodoro on JIRA https://jira.stsci.edu/browse/RCAL-895?focusedCommentId=714137#comment-714137:

Eddie Schlafly https://jira.stsci.edu/secure/ViewProfile.jspa?name=eschlafly Few questions:

  • should we add new columns to the current cat file table with the tweaked coordinates?
  • should we only update the cat file when running the ELP? Or should we update the file when running TweakRegStep (checking for meta.tweakreg_catalog_name)?
  • I assume the tweaked WCS should be applied to the results of the PSF astrometry, correct?

These are the columns present in the current cat file table:

'label','xcentroid','ycentroid','ra_centroid','dec_centroid','aper_bkg_flux','aper_bkg_flux_err','aper30_flux','aper30_flux_err','aper50_flux','aper50_flux_err','aper70_flux','aper70_flux_err','aper_total_flux','aper_total_flux_err','CI_50_30','CI_70_50','CI_70_30','flags','is_extended','sharpness','roundness','nn_label','nn_dist','isophotal_flux','isophotal_flux_err','isophotal_area','semimajor_sigma','semiminor_sigma','ellipticity','orientation','sky_orientation','ra_bbox_ll','dec_bbox_ll','ra_bbox_ul','dec_bbox_ul','ra_bbox_lr','dec_bbox_lr','ra_bbox_ur','dec_bbox_ur','flag_psf','x_psf','x_psf_err','y_psf','y_psf_err','flux_psf','flux_psf_err' ```

— Reply to this email directly, view it on GitHub https://github.com/spacetelescope/romancal/issues/1371#issuecomment-2297405589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK2E4MVXZFPDYREJWPFJ4DZSJJM5AVCNFSM6AAAAABMX33KVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGQYDKNJYHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

stscijgbot-rstdms commented 2 months ago

Comment by Mairan Teodoro on JIRA:

PR for review: #1373