spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
31 stars 28 forks source link

Variance array resampling differs from jwst #1387

Open braingram opened 2 weeks ago

braingram commented 2 weeks ago

https://github.com/spacetelescope/jwst/issues/8344 described issues and proposed updates for resampling variance arrays in jwst.

https://github.com/spacetelescope/jwst/pull/8437 updated jwst with one of the proposed solutions.

The variance array resampling in romancal doesn't appear to have similar updates and is instead using the older version of the variance array resampling.

schlafly commented 2 weeks ago

Thanks Brett. FWIW, I think in Roman we're happy to follow Webb here, e.g., as part of future refactoring to use more common code in stcal. In discussions with Stefano in the past I don't think RTB likes our current variance computations or the new Webb ones and prefers yet another option based on the weight images, but we haven't coded that up and it's only been requested insofar as I've mentioned that the current variance computation seems incorrect to me.